Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Memory Type Variable Instead of Storage Type Variable in Event to Save Gas #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Memory Type Variable Instead of Storage Type Variable in Event to Save Gas #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/vaults/BunnyPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ contract BunnyPool is IStrategyLegacy, RewardsDistributionRecipient, ReentrancyG
function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner {
require(periodFinish == 0 || block.timestamp > periodFinish, "period");
rewardsDuration = _rewardsDuration;
emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

/* ========== MODIFIERS ========== */
Expand Down
2 changes: 1 addition & 1 deletion contracts/vaults/VaultBunnyBNB.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ contract VaultBunnyBNB is VaultController, IStrategy, RewardsDistributionRecipie
function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
require(periodFinish == 0 || block.timestamp > periodFinish, "VaultBunnyBNB: reward duration can only be updated after the period ends");
rewardsDuration = _rewardsDuration;
emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

/* ========== PRIVATE FUNCTIONS ========== */
Expand Down
2 changes: 1 addition & 1 deletion contracts/vaults/VaultFlipToCake.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ contract VaultFlipToCake is VaultController, IStrategy, RewardsDistributionRecip
function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
require(periodFinish == 0 || block.timestamp > periodFinish, "VaultFlipToCake: reward duration can only be updated after the period ends");
rewardsDuration = _rewardsDuration;
emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

/* ========== PRIVATE FUNCTIONS ========== */
Expand Down
2 changes: 1 addition & 1 deletion contracts/vaults/VaultQBTBNB.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ contract VaultQBTBNB is IPresaleLocker, RewardsDistributionRecipientUpgradeable,
function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner {
require(periodFinish == 0 || block.timestamp > periodFinish, "VaultQBTBNB: period");
rewardsDuration = _rewardsDuration;
emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

function setPresaleEndTime(uint _endTime) external override onlyPresale {
Expand Down
2 changes: 1 addition & 1 deletion contracts/vaults/qubit/QubitPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ contract QubitPool is BEP20Upgradeable, IQubitPool, RewardsDistributionRecipient
require(periodFinish == 0 || block.timestamp > periodFinish, "QubitPool: Not time to set duration");
rewardsDuration = _rewardsDuration;

emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

function notifyRewardAmount(uint reward) external override(IQubitPool, RewardsDistributionRecipientUpgradeable) onlyRewardsDistribution {
Expand Down
2 changes: 1 addition & 1 deletion contracts/vaults/qubit/VaultFlipToQBT.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ contract VaultFlipToQBT is VaultController, IRewardDistributed, RewardsDistribut
function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
require(periodFinish == 0 || block.timestamp > periodFinish, "VaultFlipToQBT: reward duration can only be updated after the period ends");
rewardsDuration = _rewardsDuration;
emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

/* ========== PRIVATE FUNCTIONS ========== */
Expand Down
2 changes: 1 addition & 1 deletion contracts/vaults/relay/VaultRelayInternal.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ contract VaultRelayInternal is VaultController, IStrategy, RewardsDistributionRe
function setRewardsDuration(uint _rewardsDuration) external onlyOwner {
require(periodFinish == 0 || block.timestamp > periodFinish, "VaultRelayInternal: reward duration can only be updated after the period ends");
rewardsDuration = _rewardsDuration;
emit RewardsDurationUpdated(rewardsDuration);
emit RewardsDurationUpdated(_rewardsDuration);
}

function setRelayer(address newRelayer) external onlyOwner {
Expand Down