Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor files 61-70 in tests/resolvers/Mutation [Fixes #989] #1014

Merged
merged 30 commits into from
Feb 6, 2023

Conversation

anshgoyalevil
Copy link
Contributor

What kind of change does this PR introduce?
This PR introduces the refactoring of tests in tests/resolvers/Mutation from file 61-70

Issue Number:

Fixes #989

Did you add tests for your changes?
Yes

Snapshots/Videos:
image

If relevant, did you update the documentation?
Not Required.

Summary
This PR introduces the refactoring of tests in tests/resolvers/Mutation from file 61-70

Does this PR introduce a breaking change?
No

Other information
No

Have you read the contributing guide?
Yes

@xoldd
Copy link
Contributor

xoldd commented Feb 6, 2023

@anshgoyalevil what's the coverage for authDirective?

@anshgoyalevil
Copy link
Contributor Author

@anshgoyalevil what's the coverage for authDirective?

at 100%

@anshgoyalevil
Copy link
Contributor Author

The workflow failed due to the issue #1010

Please re-run it.

@xoldd
Copy link
Contributor

xoldd commented Feb 6, 2023

Hmmmmm why does it not show the coverage?

@codecov-commenter
Copy link

Codecov Report

Merging #1014 (e32280a) into develop (c583cf3) will increase coverage by 0.38%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #1014      +/-   ##
===========================================
+ Coverage    93.96%   94.35%   +0.38%     
===========================================
  Files          154      154              
  Lines         9121     9121              
  Branches       797      801       +4     
===========================================
+ Hits          8571     8606      +35     
+ Misses         549      514      -35     
  Partials         1        1              
Impacted Files Coverage Δ
src/directives/authDirective.ts 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anshgoyalevil
Copy link
Contributor Author

Hmmmmm why does it not show the coverage?

Really confused. Seems like it's an issue with the Codecov workflow

@palisadoes palisadoes requested review from palisadoes and removed request for noman2002 February 6, 2023 18:21
@palisadoes palisadoes merged commit 5438691 into PalisadoesFoundation:develop Feb 6, 2023
@anshgoyalevil anshgoyalevil deleted the fix-03 branch February 6, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: tests/resolvers/Mutation [File 61 to File 70]
4 participants