-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoMongo: Restore Test CodeCov GitHub Action to the develop-postgres
branch
#2854
Comments
@varshith257 PTAL |
@palisadoes can you please assign this issue to me |
@VanshikaSabharwal You can take look at the reference PR I have done for admin |
Yes @varshith257 I'll check it out. |
@varshith257 Can you please share link of that PR. |
@palisadoes @varshith257 is the name assigned to secrets here correct? |
Yes |
This has to be reopened. I just remembered that CodeCov data will not be sent to the CodeCov website until the post merge push. This was done in the push.yml file in the Use this as an example |
Okay @palisadoes i am doing it |
Please submit another PR. The push failed. |
Hi @palisadoes, the push failed because pnpm was not installed on the CI runner. I have now updated the workflow to include the installation of pnpm before running the tests. I will submit another PR to resolve this. Thanks for your patience! |
This is taking too much time. 5 unsuccessful PRs. I'm going to have to assign this to someone else. |
Unassigning. |
can i work on this |
@bandhan-majumder I spoke to @VanshikaSabharwal and there may be a solution. I'm going to reassign it back. |
Is this issue resolved @palisadoes |
Yes. Thanks |
We now need to create issues to test the code base: https://app.codecov.io/gh/PalisadoesFoundation/talawa-api/tree/develop-postgres/src?displayType=list |
can i help creating test issues @palisadoes |
It's a lot of work. You are going to need help |
I can do it. What about creating a template instead? Should I add a test issue template? @palisadoes |
Ask for help. If it's split up with 4-5 people it will be even faster |
Yes @palisadoes you are right |
We can work together on this issue @bandhan-majumder |
yes. just wait I am adding an issue template so it becomes easier to create test issue @VanshikaSabharwal |
And @palisadoes i think i have opened these type of test coverage issues |
Yes @bandhan-majumder i created tests before as well. And @palisadoes made template that time. So we can use that template. It'll be easier and better this way. |
So @bandhan-majumder Do you want me to share that template created by @palisadoes before for test coverage issue? |
please go through the conversation above. @palisadoes provided a template. following that |
Okkay gotcha great. I was talking abt same template |
@bandhan-majumder I think we can communicate better on slack. Once you have created the template we should discuss further on slack i think |
Waiting for my PR to get merged in |
Describe the bug
develop-postgres
branch.biome
in thedevelop-postgres
branch.vite
in thedevelop
branch. Thedevelop
GitHub action file can be found here:To Reproduce
Steps to reproduce the behavior:
develop-postgres
Expected behavior
develop-postgres
Actual behavior
Screenshots
Additional details
Related Issues:
CONTRIBUTING.md
Testing section to coverjest
andvitest
talawa-admin#3270develop-postgres
branch #2854Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
Reference PR:
The text was updated successfully, but these errors were encountered: