Export JSONPatcherProxy as ES Module, #57
Conversation
adjust tests to use ES Modules
|
I will review tomorrow, but we can already see that Travis config needs to be updated. |
(from 2.2.1), to use ES Modules
do not run benchmarks on `npm run test`
|
Travis fixed https://travis-ci.org/Palindrom/JSONPatcherProxy/builds/575272306 |
|
The last Travis build to check is at https://travis-ci.org/Palindrom/JSONPatcherProxy/builds/575272306, I have no idea why the last commit is not visible here (6e72454). |
to refresh GitHub and Travis
There was a problem hiding this comment.
Tested by running npm run build, npm run test, npm run bench, running the Jasmine spec runner in Chrome and FF and reading through the source code.
Jasmine spec runner does not work in Edge/EdgeHTML, but we decided to not care about that. It doesn't mean a flaw in the library (which is transpiled with Webpack), but a "flaw" of using ES Module directly in the spec runner.
Jasmine spec runner does not show benchmarks in Firefox, because of no availability of importmaps in that browser. That is OK.
adjust tests to use ES Modules
requires
npm link fast-json-patchto Starcounter-Jack/JSON-Patch#232