Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #34

Merged
merged 5 commits into from
Jun 1, 2019
Merged

Bump dependencies #34

merged 5 commits into from
Jun 1, 2019

Conversation

warpech
Copy link
Contributor

@warpech warpech commented May 30, 2019

Bumped dependencies because the project did not build in MacOs
Copied Webpack configuration from Palindrom
Moved "fast-json-patch" to devDependencies, because it is only used in the test benchmark.

@warpech
bump dependencies
67e2c99 
Bumped dependencies because the project did not build in MacOs
Copied Webpack configuration from Palindrom
Moved "fast-json-patch" to devDependencies, because it is only used in the test benchmark.
@warpech warpech requested a review from tomalec May 30, 2019 16:05
@tomalec
Copy link
Member

tomalec commented May 31, 2019

I think fast-json-pacth was used to define a type in TS https://github.com/Palindrom/JSONPatcherProxy/blob/master/index.d.ts#L8 which seems outdated looking at line 1. Any idea what to do with it?

warpech added 4 commits June 1, 2019 15:48
@warpech
remove redundant reporter
44befb6 
that's causing Jasmine 3.x to fail
@warpech
revert fast-json-patch as dependency
5f94674 
because it is used in "index.d.ts"
@warpech
fix usage of jsdom v15
39ef71d 
because "npm run bench" failed
@warpech
use latest LTS version of Node for building
badf116 
because build failed with Node 6
@warpech
Copy link
Contributor Author

warpech commented Jun 1, 2019

I think fast-json-pacth was used to define a type in TS https://github.com/Palindrom/JSONPatcherProxy/blob/master/index.d.ts#L8 which seems outdated looking at line 1. Any idea what to do with it?

Thanks for noticing! I reverted it, because the type definitions in fast-json-patch indeed look very solid. It turned out I needed to fix few more things for Travis. I think it is good to merge now.

@warpech warpech merged commit ab283ab into master Jun 1, 2019
@warpech warpech deleted the bump-versions branch June 5, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalec tomalec tomalec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warpech @tomalec