-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering out non-significiant changes Palindrom behavior #58
Comments
tomalec
added a commit
to Palindrom/Palindrom
that referenced
this issue
Sep 5, 2019
tomalec
changed the title
Filtering out non-significiant changes breaks Palindrom
Filtering out non-significiant changes Palindrom behavior
Sep 5, 2019
I vote for option 2 with clarification in JSONPatcherProxy and Palindrom docs. Reasoning: Anyone who uses numbers above Option 1 would be a performance degradation. |
tomalec
added a commit
that referenced
this issue
Sep 5, 2019
tomalec
added a commit
that referenced
this issue
Sep 6, 2019
Add note about ignoring changes above MAX_SAFE_INTEGER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@warpech, @eriksunsol #45 changes Palindrom behavior in respect of numbers
> Number.MAX_SAFE_INTEGER
.This change checks that
Number.MAX_SAFE_INTEGER == Number.MAX_SAFE_INTEGER +1 // true
and do not emit a patch, therefore such error is not cough by Palindrom's validation.And the tests that are failing are:
WDYT of
JSONPatcherProxy
?as I cannot think of any other solution.
You can check the behavior at https://github.com/Palindrom/Palindrom/compare/update-deps?expand=1
https://travis-ci.org/Palindrom/Palindrom/builds/581106763
The text was updated successfully, but these errors were encountered: