Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API #6874

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

Micalling
Copy link
Contributor

No description provided.

Copy link

paddle-bot bot commented Sep 17, 2024

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6874.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

参数
::::::::::::

- **parameters** (ParameterDict|OrderedDict|list[(key, Tensor)],可选) - 可迭代的 Parameters。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 参数描述和英文保持一致吧。
  • 英文参数名好像也写错了,写成 values 了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我把那个value改掉吧
PaddlePaddle/Paddle#68625
请review @sunzhongkai588

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaddlePaddle/Paddle#68625
这个是修改英文参数的pr,请review,然后对应的docs也改掉了。
另外 PaddlePaddle/Paddle#68268 这个也跑完了的 @sunzhongkai588

@Micalling
Copy link
Contributor Author

image
请问这是我案例代码没写对吗,我是参考的ParameterList
@sunzhongkai588

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码风格检查没通过,CI没通过


| PyTorch | PaddlePaddle | 备注 |
| ------- | ------------ | ----------------------------------- |
| values | parameters | 可迭代的 Parameters,参数名不一致。 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个加一个仅字,仅参数名不一致

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的好的,已经修改了,请review

@Micalling
Copy link
Contributor Author

image
@sunzhongkai588 这个好像需要你这里review

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit a42a1cd into PaddlePaddle:develop Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor PaddlePaddle Hackathon 飞桨黑客松活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants