[Cherry-pick ] do not crash vdl when logdir is missing (#1149) #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into do_not_crash_vdl_when_logdir_is_missing_cherry_pick
…into do_not_crash_vdl_when_logdir_is_missing_cherry_pick
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当用户没有指定logdir参数时，尽管后台会报错误，但是可能为了让静态图页面能正常使用，之前的实现并没有选择退出程序，加入Profiler功能的时候，如果没有指定logdir参数会触发错误而退出程序，该pr修复了这一问题。