Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon 7th】Remove parser.add_argument #3878

Merged
merged 11 commits into from
Nov 14, 2024
Merged

【Hackathon 7th】Remove parser.add_argument #3878

merged 11 commits into from
Nov 14, 2024

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Nov 9, 2024 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

  1. 在Bin文件夹的脚本中，会通过 parser = default_argument_parser() 获取预配置的参数名，但是在 main 中又重复定义了参数名，导致报错。
  2. Example中 README命令和实际脚本不一致，并且提供的预训练模型无法推理
  3. static_model.forward.code 在最新的版本中已经不支持使用了，通过try-except执行

@mergify mergify bot added the S2T asr/st label Nov 9, 2024
@Liyulingyue Liyulingyue mentioned this pull request Nov 9, 2024
Open
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 12, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 12, 2024
@Liyulingyue Liyulingyue requested a review from zxcd November 13, 2024 11:29
zxcd
zxcd approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd zxcd merged commit 419af45 into PaddlePaddle:develop Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxcd zxcd zxcd approved these changes

Assignees
No one assigned
Labels
contributor Example README S2T asr/st
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Liyulingyue @zxcd