Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Install]rm protobuf in setup.py #2853

Merged
merged 3 commits into from
Jan 30, 2023
Merged

[Install]rm protobuf in setup.py #2853

merged 3 commits into from
Jan 30, 2023

Conversation

yt605155624
Copy link
Collaborator

@yt605155624 yt605155624 commented Jan 30, 2023 •
edited
Loading

rm protobuf in setup.py
rm paddleaudio's depandences in setup.py of paddlespeech

@yt605155624 yt605155624 added this to the r1.4.0 milestone Jan 30, 2023
@yt605155624 yt605155624 requested a review from lym0302 January 30, 2023 09:12
@mergify mergify bot added the Installation label Jan 30, 2023
@yt605155624 yt605155624 self-assigned this Jan 30, 2023
@yt605155624 yt605155624 requested a review from SmileGoat January 30, 2023 10:50
SmileGoat
SmileGoat approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@SmileGoat SmileGoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SmileGoat SmileGoat merged commit b5764e9 into PaddlePaddle:develop Jan 30, 2023
@yt605155624 yt605155624 deleted the fix_protobuf_version branch January 30, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmileGoat SmileGoat SmileGoat approved these changes

@lym0302 lym0302 Awaiting requested review from lym0302

Assignees

@yt605155624 yt605155624

Labels
Documentation Installation
Projects
PaddleSpeech
Status: Done
Milestone
r1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yt605155624 @SmileGoat