Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[s2t] DataParallel init method changed, fixed conformer could not multi-gpu training and don't affect dy2st #2372

Merged
merged 6 commits into from
Sep 13, 2022
Merged

[s2t] DataParallel init method changed, fixed conformer could not multi-gpu training and don't affect dy2st #2372

merged 6 commits into from
Sep 13, 2022

Conversation

Zth9730
Copy link
Contributor

@Zth9730 Zth9730 commented Sep 9, 2022

PR types

Bug fixes

PR changes

Models

Describe

fix dp init

@mergify mergify bot added S2T asr/st Server labels Sep 9, 2022
zh794390558
zh794390558 reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码有format吗？

paddlespeech/s2t/training/trainer.py Show resolved Hide resolved
zh794390558
zh794390558 reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title说明下修复的bug是什么

@Zth9730 Zth9730 added this to the r1.2.0 milestone Sep 9, 2022
@Zth9730 Zth9730 changed the title [s2t] fix DataParallel init [s2t] DataParallel init method changed, fixed conformer could not multi-gpu training and don't affect dy2st Sep 9, 2022
zh794390558
zh794390558 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zh794390558 zh794390558 merged commit 07f566e into PaddlePaddle:develop Sep 13, 2022
@lym0302 lym0302 mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yt605155624 yt605155624 yt605155624 left review comments

@zh794390558 zh794390558 zh794390558 approved these changes

Assignees
No one assigned
Labels
S2T asr/st Server
Projects
None yet
Milestone
r1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Zth9730 @zh794390558 @yt605155624