Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tts] add mix frontend #2143

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[tts] add mix frontend #2143

merged 1 commit into from
Jul 13, 2022

Conversation

lym0302
Copy link
Contributor

@lym0302 lym0302 commented Jul 12, 2022

PR types
New feature

PR changes
add mixed frontend

Describe
add mixed frontend

@lym0302 lym0302 requested a review from yt605155624 July 12, 2022 12:37
@mergify mergify bot added the T2S label Jul 12, 2022
@lym0302 lym0302 added this to the r1.1.0 milestone Jul 12, 2022
@@ -29,6 +29,7 @@

from paddlespeech.t2s.datasets.data_table import DataTable
from paddlespeech.t2s.frontend import English
from paddlespeech.t2s.frontend.mix_frontend import Mix_Frontend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类名不要加下划线

sentence: str,
merge_sentences: bool=True,
get_tone_ids: bool=False,
robot: bool=False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robot print_info 这两个参数在此处无用可以删掉

content, merge_sentences=True)

phones_seg.append(input_ids["phone_ids"][0])
phones_seg.append(self.sp_id_tensor)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文中间加的 sp 要用个变量控制下?

@yt605155624 yt605155624 merged commit f4ac0c7 into PaddlePaddle:develop Jul 13, 2022
@lym0302 lym0302 deleted the mix_front branch July 13, 2022 05:51
@lym0302 lym0302 restored the mix_front branch August 25, 2022 06:10
@lym0302 lym0302 deleted the mix_front branch August 25, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants