[server] add streaming am infer #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zh794390558
reviewed
Apr 18, 2022
yt605155624
reviewed
Apr 19, 2022
| self.voc_block = voc_block | ||
| self.voc_pad = voc_pad | ||
|
|
||
| def get_model_info(self, step, model_name, ckpt, stat): |
There was a problem hiding this comment.
此处是否也加上 typehint?
step: str, model_name: str, ckpt: Path/str, 等
| """get model information | ||
|
|
||
| Args: | ||
| step (string): am or voc |
There was a problem hiding this comment.
string -> str, python 不用 string
| stat (string): stat file, including mean and standard deviation | ||
|
|
||
| Returns: | ||
| model, model_mu, model_std |
There was a problem hiding this comment.
返回值
Returns:
Tensor: xxx
np.array : xxx
np.array : xxx
但是其实调用函数可能也不需要写这么多 docstring, 模型代码里面一般要写得清楚一点
|
|
||
| return model, model_mu, model_std | ||
|
|
||
| def _get_pretrained_path(self, tag: str) -> os.PathLike: |
There was a problem hiding this comment.
TTSExecutor 里面有这个函数了，是否可以不用写了
突然发现 TTSExecutor 里面这个函数也不用写，因为基类都写了..
| @@ -116,11 +473,18 @@ def __init__(self, name=None): | |||
| super(TTSEngine, self).__init__() | |||
There was a problem hiding this comment.
我们基类直接用这个 super().init()
|
|
||
| if block_size == -1: | ||
| return [data] | ||
|
|
There was a problem hiding this comment.
我这在区分 am 和 voc 的时候是用 filed, 如果保持一致，用户在看源码的时候可能会更容易理解变量的含义
zh794390558
reviewed
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
add streaming am infer
Describe
add streaming am infer