Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vec]add vector necessary note, test=doc #1690

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

LeoMax-Xiong
Copy link
Contributor

@LeoMax-Xiong LeoMax-Xiong commented Apr 12, 2022

PR types

PR changes

Describe

add vector necessary note
fix #1689

@LeoMax-Xiong LeoMax-Xiong added the Vector SID/LID/etc. label Apr 12, 2022
@LeoMax-Xiong LeoMax-Xiong added this to the r1.0.0a milestone Apr 12, 2022
@LeoMax-Xiong LeoMax-Xiong self-assigned this Apr 12, 2022
@LeoMax-Xiong LeoMax-Xiong linked an issue Apr 12, 2022 that may be closed by this pull request
@mergify mergify bot added the Example label Apr 12, 2022
Copy link
Collaborator

@zh794390558 zh794390558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -42,8 +42,16 @@ epochs: 10
save_interval: 10
log_interval: 10
learning_rate: 1e-8
max_lr: 1e-3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字段后面多加些注释

if config.global_embedding_norm:
mean_var_norm_emb = InputNormalization(
norm_type="global",
mean_norm=config.embedding_mean_norm,
std_norm=config.embedding_std_norm)

# stage 7: score norm need the imposters dataset
# we select the train dataset as the idea imposters dataset
# and we select the config.n_train_snts utterance to as the final imposters dataset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最好按照kaldi的名字风格命名, n_train_utts。看声纹代码里有很多命名方式很传统,不好理解。

@LeoMax-Xiong LeoMax-Xiong merged commit 7988d0f into PaddlePaddle:develop Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Example Vector SID/LID/etc.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[vec]complete the speaker verification notes and speakers in yaml
3 participants