Skip to content

Conversation

thejjw
Copy link
Contributor

@thejjw thejjw commented May 27, 2025

Introduce a check for language support in the PP-OCRv5 model
context: #15373

The language check for v5 is based on the readme documentation that says "🌐 Single-model support for five text types - eamlessly process Simplified Chinese, Traditional Chinese, Simplified Chinese Pinyin, English and Japanse within a single model."

Copy link

paddle-bot bot commented May 27, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented May 27, 2025

CLA assistant check
All committers have signed the CLA.

@thejjw thejjw marked this pull request as ready for review May 27, 2025 05:48
@thejjw thejjw mentioned this pull request May 27, 2025
3 tasks
@thejjw
Copy link
Contributor Author

thejjw commented Jun 5, 2025

commit fa621ef integrated yesterday includes similar code to my pr that checks the languages and effectively resolves the issue, albeit without giving proper credit one might say.

i don't know why my pr is left without reaction but i guess you can close the issue.

thanks.

@cuicheng01
Copy link
Collaborator

Thank you for taking the time to help fix the issue. In fact, we need to change the default model here from mobile to server and add relevant monitoring. Therefore, your PR has not been merged. We really appreciate your initiative in addressing this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants