Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support qwen2_5_vl #9924

Merged
merged 4 commits into from
Feb 24, 2025
Merged

support qwen2_5_vl #9924

merged 4 commits into from
Feb 24, 2025

Conversation

chang-wenbin
Copy link
Contributor

@chang-wenbin chang-wenbin commented Feb 21, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Performance optimization

PR changes

Others

Description

support qwen2_5_vl & support multi model mapping

Copy link

paddle-bot bot commented Feb 21, 2025

Thanks for your contribution!

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.33%. Comparing base (b8ebe3e) to head (7b51380).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...dlenlp/experimental/transformers/qwen2/modeling.py 0.00% 6 Missing ⚠️
paddlenlp/transformers/auto/configuration.py 75.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (30.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (51.33%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9924      +/-   ##
===========================================
- Coverage    51.33%   51.33%   -0.01%     
===========================================
  Files          745      745              
  Lines       118592   118600       +8     
===========================================
+ Hits         60884    60886       +2     
- Misses       57708    57714       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -238,7 +238,7 @@ def __init__(self, mapping):

def __getitem__(self, key):
# NOTE: (changwenbin) This is to enable the qwen2_vl language model to use qwen2 reasoning optimization
if key == "qwen2_vl":
if key == "qwen2_vl" or key == "qwen2_5_vl":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里写个通用的mapping吧,这种写法不推荐

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 0b26a02 into PaddlePaddle:develop Feb 24, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants