-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support qwen2_5_vl #9924
support qwen2_5_vl #9924
Conversation
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (30.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #9924 +/- ##
===========================================
- Coverage 51.33% 51.33% -0.01%
===========================================
Files 745 745
Lines 118592 118600 +8
===========================================
+ Hits 60884 60886 +2
- Misses 57708 57714 +6 ☔ View full report in Codecov by Sentry. |
@@ -238,7 +238,7 @@ def __init__(self, mapping): | |||
|
|||
def __getitem__(self, key): | |||
# NOTE: (changwenbin) This is to enable the qwen2_vl language model to use qwen2 reasoning optimization | |||
if key == "qwen2_vl": | |||
if key == "qwen2_vl" or key == "qwen2_5_vl": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里写个通用的mapping吧,这种写法不推荐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before submitting
tests
folder. If there are codecov issues, please add tests cases first.PR types
Performance optimization
PR changes
Others
Description
support qwen2_5_vl & support multi model mapping