Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support float8 dtype storage. #9906

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Feb 19, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

New features

PR changes

Others

Description

Support float8 dtype storage.

Copy link

paddle-bot bot commented Feb 19, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

return new_t
# return paddle.to_tensor(tensor.view(np.int8), dtype=paddle.float8_e4m3fn)
raise ValueError()
return paddle.to_tensor(tensor)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trick 绕过fp8赋值。

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.33%. Comparing base (08183d7) to head (f97937b).
Report is 11 commits behind head on develop.

❌ Your project check has failed because the head coverage (51.33%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9906      +/-   ##
===========================================
- Coverage    51.40%   51.33%   -0.07%     
===========================================
  Files          745      745              
  Lines       118373   118596     +223     
===========================================
+ Hits         60853    60886      +33     
- Misses       57520    57710     +190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return paddle.to_tensor(tensor)


class EextendDtypeNumpySafe(unittest.TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants