Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Checkpoint] Fix expert parallel #9821

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix expert parallel and add unittest.

Copy link

paddle-bot bot commented Jan 24, 2025

Thanks for your contribution!

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 52.21%. Comparing base (3967f76) to head (f018151).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...p/trainer/unified_checkpoint/unified_checkpoint.py 0.00% 24 Missing ⚠️
paddlenlp/trainer/unified_checkpoint/utils.py 20.00% 4 Missing ⚠️
...r/unified_checkpoint/sharding_split_param_utils.py 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (3.12%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9821      +/-   ##
===========================================
- Coverage    52.43%   52.21%   -0.23%     
===========================================
  Files          731      730       -1     
  Lines       116411   115828     -583     
===========================================
- Hits         61037    60475     -562     
+ Misses       55374    55353      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay DesmonDay force-pushed the fix_split_param_for_quant branch from 733bd5a to 8bed006 Compare January 26, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant