Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokenizer] Fix tokenizer of llama3.3 #9641

Merged

Conversation

DrownFish19
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Description

Fix tokenizer of llama3.3

Copy link

paddle-bot bot commented Dec 16, 2024

Thanks for your contribution!

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (dc0ca03) to head (9315125).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/llama/modeling.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9641      +/-   ##
===========================================
+ Coverage    52.76%   52.80%   +0.04%     
===========================================
  Files          710      710              
  Lines       111231   111234       +3     
===========================================
+ Hits         58688    58742      +54     
+ Misses       52543    52492      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1601,7 +1601,8 @@ def _prepare_decoder_attention_mask(attention_mask, input_shape, past_key_values
expanded_attn_mask = expanded_attn_mask.astype(dtype)
expanded_attn_mask = paddle.where(expanded_attn_mask, x, y).astype(dtype)
else:
expanded_attn_mask = paddle.where(expanded_attn_mask, 0.0, paddle.finfo(dtype).min).astype(dtype)
expanded_attn_mask = paddle.where(expanded_attn_mask.cast("bool"), 0.0, paddle.finfo(dtype).min)
expanded_attn_mask = expanded_attn_mask.astype(dtype)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里PaddleNLP-CI已经验证

@ZHUI ZHUI merged commit 9eb3cfe into PaddlePaddle:develop Dec 17, 2024
9 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_20241216_fix_llama3_tokenizer branch December 17, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants