Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lora sharding v2 #9300

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix lora sharding v2 #9300

merged 1 commit into from
Oct 22, 2024

Conversation

lugimzzz
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Description

修复LoRA Sharding v2报错

Copy link

paddle-bot bot commented Oct 22, 2024

Thanks for your contribution!

Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (1dc6e18) to head (53628aa).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9300      +/-   ##
===========================================
- Coverage    52.94%   52.74%   -0.21%     
===========================================
  Files          657      661       +4     
  Lines       106533   107365     +832     
===========================================
+ Hits         56404    56627     +223     
- Misses       50129    50738     +609     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lugimzzz lugimzzz merged commit 3443b9f into PaddlePaddle:develop Oct 22, 2024
10 of 12 checks passed
@lugimzzz lugimzzz deleted the fixsd branch October 22, 2024 12:37
lvdongyi pushed a commit to lvdongyi/PaddleNLP that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants