Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] fix save_model #9287

Merged

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix save_model usage.

Copy link

paddle-bot bot commented Oct 17, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 8da4248 into PaddlePaddle:release/3.0-beta2 Oct 17, 2024
3 of 5 checks passed
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (036e1cd) to head (1cf3094).
Report is 49 commits behind head on release/3.0-beta2.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/3.0-beta2    #9287   +/-   ##
==================================================
  Coverage              52.94%   52.95%           
==================================================
  Files                    656      656           
  Lines                 106312   106315    +3     
==================================================
+ Hits                   56291    56297    +6     
+ Misses                 50021    50018    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants