Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix test_sample_generate bug. #8150

Closed
wants to merge 6 commits into from
Closed

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Mar 19, 2024

PR types

Others

PR changes

Others

Description

    # For test_sample_generate such as: NVIDIA_TF32_OVERRIDE=0 FLAGS_cudnn_deterministic=1 python3.10 -m pytest -svv tests/transformers/bloom/test_modeling.py::BloomModelTest_0::test_sample_generate
    # There are serious memory bug for this tensor slice. which use the original tensor mem ptr for cold start
    # Here we just clone the tensor to avoid this problem.
    input_ids = input_ids.clone()

Copy link

paddle-bot bot commented Mar 19, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ZHUI
❌ zhangjunjun04


zhangjunjun04 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.28%. Comparing base (d83bd5e) to head (ef44307).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8150      +/-   ##
===========================================
- Coverage    56.45%   55.28%   -1.18%     
===========================================
  Files          596      596              
  Lines        91602    92033     +431     
===========================================
- Hits         51711    50877     -834     
- Misses       39891    41156    +1265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 20, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 20, 2024
@ZHUI ZHUI closed this Mar 20, 2024
@ZHUI ZHUI reopened this Mar 20, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 20, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 20, 2024
@ZHUI ZHUI closed this Mar 20, 2024
@ZHUI ZHUI deleted the bugfix/sample_generate branch January 23, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants