[Llama2] Fix gradient accumulation for Llama2 training in auto model and add uts #7625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7625 +/- ##
===========================================
- Coverage 57.85% 57.85% -0.01%
===========================================
Files 582 582
Lines 86485 86489 +4
===========================================
+ Hits 50038 50040 +2
- Misses 36447 36449 +2 ☔ View full report in Codecov by Sentry. |
haohongxiang
force-pushed
the
fix_grad_acc_in_llama_auto
branch
5 times, most recently
from
bdfd12a to
d7ba41b
Compare
haohongxiang
force-pushed
the
fix_grad_acc_in_llama_auto
branch
from
d7ba41b to
2119b50
Compare
ZHUI
reviewed
Dec 12, 2023
| return max(self.sharding_parallel_degree, 1) * self.data_parallel_rank + self.sharding_parallel_rank | ||
| elif self.use_auto_parallel: | ||
| return self.data_parallel_rank |
There was a problem hiding this comment.
和动手有区别，自动并行的sharding是数据并行的一个优化，所以在取数据并行相关的维度时不需要考虑sharding维度
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
[Llama2] Fix gradient accumulation for Llama2 training in auto model and add uts