Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] fix LoRA unsync parameters issue #6048

Merged
merged 2 commits into from
May 30, 2023

Conversation

sijunhe
Copy link
Collaborator

@sijunhe sijunhe commented May 30, 2023

PR types

PR changes

Description

@sijunhe sijunhe requested a review from lugimzzz May 30, 2023 12:16
@paddle-bot
Copy link

paddle-bot bot commented May 30, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #6048 (89b7c31) into develop (1d776a6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6048      +/-   ##
===========================================
- Coverage    62.49%   62.49%   -0.01%     
===========================================
  Files          492      492              
  Lines        69365    69376      +11     
===========================================
+ Hits         43353    43359       +6     
- Misses       26012    26017       +5     
Impacted Files Coverage Δ
paddlenlp/layers/lora.py 57.88% <0.00%> (-0.98%) ⬇️

... and 3 files with indirect coverage changes

@lugimzzz lugimzzz merged commit 699f73a into PaddlePaddle:develop May 30, 2023
sijunhe added a commit to sijunhe/PaddleNLP that referenced this pull request May 30, 2023
lugimzzz pushed a commit that referenced this pull request May 31, 2023
* [chatglm] ignore warning for inv_freq and lm_head (#6046)

* [Bug fix] fix LoRA unsync parameters issue (#6048)

* fix styles

* remove extra print

* fix styles

* remove old lora

* fix imports

---------

Co-authored-by: Noel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants