[FastTokenizer] Add unittest for fast_tokenizer #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## develop #4339 +/- ##
===========================================
+ Coverage 36.30% 38.69% +2.38%
===========================================
Files 419 422 +3
Lines 59254 59661 +407
===========================================
+ Hits 21514 23087 +1573
+ Misses 37740 36574 -1166
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joey12300
changed the title
sijunhe
reviewed
Jan 5, 2023
| @@ -68,10 +73,38 @@ def get_input_output_texts(self, tokenizer): | |||
|
|
|||
| def test_full_tokenizer(self): | |||
There was a problem hiding this comment.
所有的单测我建议把tokenizer和fast_tokenizer分开，即分test_tokenizer和test_fast_tokenizer两个method. 如果有错，比较容易debug
There was a problem hiding this comment.
Done，新增test_fast_and_python_full_tokenizer单测，用于比较fast和python的tokenizer的输出是否一致。
sijunhe
previously approved these changes
Jan 5, 2023
wj-Mcat
requested changes
Jan 5, 2023
| pytest-xdist | ||
| fast_tokenizer_python |
There was a problem hiding this comment.
我查了下，包名应该是：fast-tokenizer-python，具体可见：https://pypi.org/project/fast-tokenizer-python/
我本地运行: pip install fast_tokenizer_python 会直接报错。
wj-Mcat
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Add unittest for fast_tokenizer