Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ft when using padded vocabulary #3936

Merged
merged 12 commits into from
Jan 4, 2023
Merged

Conversation

FrostML
Copy link
Contributor

@FrostML FrostML commented Nov 28, 2022

PR types

Function optimization

PR changes

Others

Description

  • Optimize FT when using padded vocabulary
  • Fix fp16 usage in eager mode
  • Fix UNIMO doc
  • Fix UnifiedTransformer original generation
  • Fix UNIMO origin generation
  • Fix MBART cannot generate with use_cache=False
  • Fix BART cannot generate with use_cache=False
  • Fix T5 cannot generate with use_cache=False

guoshengCS
guoshengCS previously approved these changes Dec 9, 2022
if (
getattr(paddle.fluid.framework, "_in_eager_mode_", False)
and getattr(paddle.fluid.framework, "_dygraph_tracer_", None) is not None
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否有不依赖fluid的接口来判断,另外写上注释说明需要这个分支的原因

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

必须得有 paddle.fluid.frameworkpaddle.framework 没有暴露这个变量。

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #3936 (69b2978) into develop (5cc4b21) will increase coverage by 0.00%.
The diff coverage is 51.35%.

@@           Coverage Diff            @@
##           develop    #3936   +/-   ##
========================================
  Coverage    36.30%   36.30%           
========================================
  Files          419      419           
  Lines        59222    59254   +32     
========================================
+ Hits         21498    21514   +16     
- Misses       37724    37740   +16     
Impacted Files Coverage Δ
...lenlp/ops/fast_transformer/transformer/decoding.py 7.47% <0.00%> (-0.03%) ⬇️
paddlenlp/transformers/bart/modeling.py 84.16% <44.44%> (-1.15%) ⬇️
paddlenlp/transformers/mbart/modeling.py 80.73% <44.44%> (-1.03%) ⬇️
paddlenlp/transformers/t5/modeling.py 85.18% <77.77%> (-0.11%) ⬇️
...lenlp/transformers/unified_transformer/modeling.py 82.06% <100.00%> (ø)
paddlenlp/transformers/unimo/modeling.py 82.58% <100.00%> (ø)
paddlenlp/transformers/roberta/modeling.py 90.21% <0.00%> (+0.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FrostML FrostML merged commit 640a84a into PaddlePaddle:develop Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants