Fix(qwenmoe): Fix SP issue in Qwen Moe #2741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2741 +/- ##
==========================================
Coverage ? 29.08%
==========================================
Files ? 334
Lines ? 55916
Branches ? 0
==========================================
Hits ? 16261
Misses ? 39655
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lugimzzz
reviewed
Oct 17, 2025
|
|
||
| shared_expert_output = self.shared_expert(hidden_states) | ||
| shared_expert_output = F.sigmoid(self.shared_expert_gate(hidden_states)) * shared_expert_output | ||
| shared_expert_output = self.shared_expert(residuals) |
There was a problem hiding this comment.
share expert是非splayer，输入不做gather，相当于每一张卡都只跑了部分数据，TPlayer的输入应该是完整的序列。share expert的输入也应该是gather的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Description
修复Qwen2/3 Mode系列模型开启SP并行Hang住问题