Skip to content

fix save tensor dtype #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

fix save tensor dtype #2642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paddleformers/mergekit/merge_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ def shard_lora_merge(self, base_index, shard_file, lora_config, file_type_list,
tensor = paddle.Tensor.__call__(tensor, zero_copy=True)
lora_A_tensor = paddle.Tensor.__call__(lora_A_tensor, zero_copy=True)
lora_B_tensor = paddle.Tensor.__call__(lora_B_tensor, zero_copy=True)
if self.is_cpu and is_bf16 or self.merge_config.save_to_hf:
if self.is_cpu and is_bf16:
tensor = tensor.astype("float32")
lora_A_tensor = lora_A_tensor.astype("float32")
lora_B_tensor = lora_B_tensor.astype("float32")
Expand Down
2 changes: 1 addition & 1 deletion paddleformers/transformers/model_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ def load_state_dict(
def prepare_safe_save_state_dict(state_dict, save_to_hf=False):
for k in list(state_dict.keys()):
if isinstance(state_dict[k], paddle.Tensor):
if save_to_hf:
if state_dict[k].dtype == paddle.bfloat16:
state_dict[k] = state_dict.pop(k).astype("float32").cpu().numpy().astype(ml_dtypes.bfloat16)
else:
state_dict[k] = state_dict.pop(k).cpu().numpy()
Expand Down