Skip to content

Conversation

@DrownFish19
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Models

Description

Fix precision of gate and e_score_correction_bias in Glm4Moe

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2025

CLA assistant check
All committers have signed the CLA.

@DrownFish19 DrownFish19 force-pushed the dev_20250919_fix_glm4moe branch from a3e3108 to df3b236 Compare September 19, 2025 03:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@ed81369). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/transformers/glm4_moe/modeling.py 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2637   +/-   ##
==========================================
  Coverage           ?   28.54%           
==========================================
  Files              ?      308           
  Lines              ?    54009           
  Branches           ?        0           
==========================================
  Hits               ?    15419           
  Misses             ?    38590           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paddle-bot
Copy link

paddle-bot bot commented Sep 19, 2025

Thanks for your contribution!

@DrownFish19 DrownFish19 reopened this Sep 19, 2025
Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lugimzzz lugimzzz merged commit c90f3bd into PaddlePaddle:develop Sep 19, 2025
3 of 4 checks passed
hushenwei2000 pushed a commit to hushenwei2000/PaddleFormers that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants