Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Bug fix] use pad_shape instead of img_shape for bevformer and recover the origin code where the first frame pre_bev is None #225

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FlyingQianMM
Copy link
Collaborator

  • Use pad_shape instead of img_shape for bevformer, where img_shape reserves the origin image shape and pad_shape is the image shape after padded.

  • Recover the origin codes where the first frame pre_bev is None. Present codes set the first frame pre_bev to zeros during the trainng phase in order to keep consistent with the deploy phase, but it seems to be not too right. The reasons are two below:

  1. Temporal information cannot be closed flexiblely where the pre_bev should be set as None.
  2. When temporal information is needed, pre_bev is the key and value of the temporal encoder layers. If pre_bev is None, the encoder layer will set the value of pre_bev the same as query.

@FlyingQianMM FlyingQianMM added the bug Something isn't working label Jan 30, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


luoqianhui seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@FlyingQianMM FlyingQianMM changed the title [Bug fix] use pad_shape instead of img_shape for bevformer and recover the origin code where the first frame pre_bev is None [WIP][Bug fix] use pad_shape instead of img_shape for bevformer and recover the origin code where the first frame pre_bev is None Jan 30, 2023
@nepeplwu nepeplwu self-assigned this Feb 1, 2024
@nepeplwu
Copy link
Collaborator

nepeplwu commented Feb 6, 2024

This PR conflicts with the latest code, please fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants