Add lstm with recurrent projection layer operator #7792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkuyym
reviewed
Jan 24, 2018
paddle/operators/lstmp_op.cc
Outdated
|
|
||
| void InferShape(framework::InferShapeContext* ctx) const override { | ||
| PADDLE_ENFORCE(ctx->HasInput("Input"), | ||
| "Input(Input) of LSTMP should not be null."); |
paddle/operators/lstmp_op.cc
Outdated
| if (ctx->HasInput("H0")) { | ||
| PADDLE_ENFORCE(ctx->HasInput("C0"), | ||
| "Input(C0) and Input(H0) of LSTMP should not " | ||
| "be null at the same time."); |
There was a problem hiding this comment.
Better to change to C0 must be specified when H0 provided
paddle/operators/lstmp_op.h
Outdated
| math::matmul<DeviceContext, T>(device_ctx, ordered_h0, false, | ||
| *proj_weight, false, static_cast<T>(1.0), | ||
| ordered_proj0, static_cast<T>(0.0)); | ||
| if (share_cell_act) { |
There was a problem hiding this comment.
Please consider to use string type.
kuke
commented
Jan 24, 2018
paddle/operators/lstmp_op.cc
Outdated
|
|
||
| void InferShape(framework::InferShapeContext* ctx) const override { | ||
| PADDLE_ENFORCE(ctx->HasInput("Input"), | ||
| "Input(Input) of LSTMP should not be null."); |
paddle/operators/lstmp_op.cc
Outdated
| if (ctx->HasInput("H0")) { | ||
| PADDLE_ENFORCE(ctx->HasInput("C0"), | ||
| "Input(C0) and Input(H0) of LSTMP should not " | ||
| "be null at the same time."); |
paddle/operators/lstmp_op.h
Outdated
| math::matmul<DeviceContext, T>(device_ctx, ordered_h0, false, | ||
| *proj_weight, false, static_cast<T>(1.0), | ||
| ordered_proj0, static_cast<T>(0.0)); | ||
| if (share_cell_act) { |
qingqing01
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7547