[API Compatibility] Add nn.Constant/Reflection/Replication/Circular Pad layers #76136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Oct 30, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #76136 +/- ##
==========================================
Coverage ? 97.22%
==========================================
Files ? 2
Lines ? 72
Branches ? 0
==========================================
Hits ? 70
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
zhwesky2010
reviewed
Oct 31, 2025
| from .utils.spectral_norm_hook import spectral_norm # noqa: F401 | ||
|
|
||
| SiLU = Silu | ||
| ReflectionPad1d = ReflectionPad1D |
There was a problem hiding this comment.
你也可以conv2d=Conv2D那些也挪出来，统一放一个位置。
python/paddle/nn/layer/common.py
Outdated
| return f'padding={self.padding}, value={self.value}, data_format={self._data_format}{name_str}' | ||
|
|
||
|
|
||
| class ReplicationPad1D(Layer): |
There was a problem hiding this comment.
1D是不是可以都继承下class PadD
2D都继承Pad2D
3D都继承Pad3D
增加代码复用，减少维护成本。
之前有点遗漏，这三个API也补上吧。可以这个PR或者下个PR提 |
Done |
|
/re-run all-failed |
|
@SigureMo 求 Review ~ |
SigureMo
reviewed
Nov 4, 2025
SigureMo
reviewed
Nov 4, 2025
Co-authored-by: Nyakku Shigure <[email protected]>
SigureMo
approved these changes
Nov 4, 2025
|
/re-run all-failed |
zhwesky2010
changed the title
AlAuAu
pushed a commit
to AlAuAu/Paddle
that referenced
this pull request
Nov 6, 2025
…ad layers (PaddlePaddle#76136) * Add nn.Constant/Reflection/Replication Pad layers * Refine on comment: Rename 1d/2d/3d to 1D2D3D * Fix sample code * Fix test error * Rerun CI * Refactor pad layers * Fix zeropad test * Fix unittest * Add CircularPad1D/2D/3D * Add CircularPad1D/2D/3D * Skip circular pad 3d test on xpu * Skip circular pad ut on XPU * correct return type of _npairs * correct return type of _npairs with concrete type Co-authored-by: Nyakku Shigure <[email protected]> --------- Co-authored-by: Nyakku Shigure <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
New features
Description
PaConvert 测试：