Skip to content

Conversation

@zhengshengning
Copy link
Contributor

@zhengshengning zhengshengning commented Aug 18, 2025

PR Category

Operator Mechanism

PR Types

New features

Description

下沉paddle.isfinite 、paddle.isinf 和 paddle.isnan 到C++层,支持Torch的传参方法

  1. 与torch仅参数名不一样,paddle实现是直接掉_C_ops
  2. 修改ops.yaml。x对应input,可以使用默认的映射关系 (use_default_mapping : True)
  3. 删掉原有实现,使用from _C_ops import isfinite isinf isnan代替
  4. 文档和函数定义通过add_doc_and_signature(name,doc,signature)绑定
  5. 添加静态图和动态图的单测
  6. 删掉报错的老静态图(Old IR)的单测

pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Aug 18, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010
zhwesky2010 previously approved these changes Aug 20, 2025
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for delet depracated UT

zyfncg
zyfncg previously approved these changes Aug 20, 2025
@zhengshengning zhengshengning dismissed stale reviews from zyfncg and zhwesky2010 via 5422058 August 20, 2025 11:16
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@1d9d7a3). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #74703   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         3           
  Branches           ?         0           
===========================================
  Hits               ?         3           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhengshengning
Copy link
Contributor Author

/re-run all-failed

@swgu98 swgu98 merged commit 7731d1c into PaddlePaddle:develop Aug 21, 2025
150 of 160 checks passed
Luckycheng222 pushed a commit to Luckycheng222/Paddle that referenced this pull request Aug 25, 2025
… into C++ (PaddlePaddle#74703)

* paddle.isfinite、paddle.isinf and paddle.isnan sink into C++

* fix

* remove oldIR unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants