[0-size Tensor No.12] Add 0-size Tensor support for as_real API. #73742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
DanielSun11
requested changes
Jul 4, 2025
Comment on lines
+32
to
+46
| if (out && out->numel() == 0) { | ||
| if (x.dtype() == DataType::COMPLEX64) { | ||
| out->set_type(DataType::FLOAT32); | ||
| } else if (x.dtype() == DataType::COMPLEX128) { | ||
| out->set_type(DataType::FLOAT64); | ||
| } else { | ||
| PADDLE_THROW(common::errors::Unimplemented( | ||
| "as_real is not supported data type (%s).", | ||
| DataTypeToString(x.dtype()))); | ||
| } | ||
| out->set_offset(x.offset()); | ||
| out->ResetHolder(x.Holder()); | ||
| out->ShareInplaceVersionCounterWith(x); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
修复似乎没有必要。as_real 应该已经被修过了，请修复之前先运行下paddleapitest 尝试能否复现问题，然后进行修复。如果复现不了问题需要添加几个0-size的单测
Contributor
Author
There was a problem hiding this comment.
感谢您的回复，经过进一步研究发现有效修改位于paddle/phi/kernels/stride/as_complex_kernel.cc中的AsComplexStridedKernel函数
Contributor
There was a problem hiding this comment.
可以添加几个单测，完善0-size Tensor的验证机制
|
Sorry to inform you that 6a725bd's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Contributor
|
close due to the following PR is merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
修复：
a. 在Paddle代码中检索def as_real，发现as_real的核心实现调用的是_C_ops的as_real
b. 以_C_ops的as_real在paddle/phi/ops/yaml中检索，发现as_real的InferMeta函数使用为：AsRealInferMeta
c. 在代码中检索AsRealInferMeta，其函数体位于paddle\phi\infermeta\unary.cc，检查其对于0-size张量发现并无直接的相关操作
d. 在paddle/phi/kernels中检索as_real（asreal），寻找有关Kernel的相关实现。发现存在函数AsRealStridedKernel，添加对于0-size问题的判定
PaddleAPITest测试结果：
pcard-67164