Skip to content

Conversation

@DanielSun11
Copy link
Contributor

@DanielSun11 DanielSun11 commented May 28, 2025

PR Category

Execute Infrastructure

PR Types

Improvements

Description

涉及的API:

  • 调用split kernel:paddle.Tensor.split、paddle.dsplit、paddle.hsplit、paddle.split、paddle.tensor_split
  • 调用concat kernel:paddle.concat、paddle.column_stack、paddle.dstack、paddle.hstack、paddle.row_stack、paddle.vstack

split和concat互为正反向的关系,因此将这两个kernel修复上述API都可恢复正常。splitkernel很早之前就支持了0-size Tensor,检查之后发现没有问题。
对concat的前向和反向kernel进行了修复,由于concat的输出为0-size Tensor时,输入一定全为0-size Tensor,因此只需考虑判断+return即可,无需考虑初始化过程。

paddleAPITest 回测
image

image

pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented May 28, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@DanielSun11
Copy link
Contributor Author

/re-run all-failed

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (develop@f1b794d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/kernels/cpu/concat_kernel.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #72988   +/-   ##
==========================================
  Coverage           ?   50.00%           
==========================================
  Files              ?        1           
  Lines              ?        2           
  Branches           ?        0           
==========================================
  Hits               ?        1           
  Misses             ?        1           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 98db28a into PaddlePaddle:develop May 30, 2025
50 of 51 checks passed
@DanielSun11 DanielSun11 deleted the fix_split branch September 18, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants