-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[0-size Tensor No.76-79] Add 0-size Tensor support for i0 #72826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
#71542 修复了GPU kernel使用的ElementwiseKernel。请使用paddleAPITest复测一下修改后的CPU版本。 |
|
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/kernels/gpu/i0_kernel.cu#L30. I0Kernel 调用的ElementwiseKernel。 I1Kernel 同理。GPU版本应该不需要修复了。请解决一下CI报错,非必要不要新增单测文件,CI容易不过而且还会增加CI的执行时间。 |
已修改CI已完成 |
|
PR-CI-Coverage 结果不正常,暂时不能豁免,需要完善一下:
|
已修改为OpTest类,check_grad检测反向, op_test.py中会列出place测试,这样可以测试到CPU环境 |
DanielSun11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/legacy_test/test_i0_op_0size.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
无需新建单测文件,将单测类合并进原来的单测文件就好
wanghuancoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



PR Category
Execute Infrastructure
PR Types
Improvements
Description
如果不修改代码测试i0, i1, i0e, i1e没有问题,不确定是否继续修改


代码中size为0,所以没有影响
