【BUPT】【Paddle Tensor 第二期 API支持 0-size Tensor】paddle.matrix_norm 支持 0-size tensor #70186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
74 tasks
| } | ||
| auto dim_x = x.dims(); |
Comment on lines
+74
to
+79
| for (int i = 0; i < dim_x.size() - 2; ++i) { | ||
| out_dims_vec[i] = dim_x[i]; | ||
| } | ||
| out->Resize(phi::make_ddim(out_dims_vec)); | ||
| dev_ctx.template Alloc<int64_t>(out); | ||
| return; |
There was a problem hiding this comment.
被删除的axis不一定是最后两个吧？
axis (list|tuple，可选) - 使用范数计算的轴。axis 为 [-2,-1],否则 axis 必须为长度为 2 的 list|tuple。
Comment on lines
+85
to
+86
| out_dims_vec[dim_x.size() - 2] = 1; | ||
| out_dims_vec[dim_x.size() - 1] = 1; |
Comment on lines
+1384
to
+1417
| x1 = paddle.full((0, 0), 1.0, dtype='float32') | ||
| y1_p = paddle.linalg.matrix_norm(x1, p=1, axis=[0, -1]) | ||
| self.assertRaises( | ||
| ValueError, paddle.linalg.matrix_norm, x1, p=2, axis=[0, -1] | ||
| ) | ||
| y1_fro_keepdimfalse = paddle.linalg.matrix_norm( | ||
| x1, p='fro', axis=[0, -1], keepdim=False | ||
| ) | ||
| y1_fro_keepdimtrue = paddle.linalg.matrix_norm( | ||
| x1, p='fro', axis=[0, -1], keepdim=True | ||
| ) | ||
| x2 = paddle.full((2, 2, 0), 1.0, dtype='float32') | ||
| y2_fro_keepdimfalse = paddle.linalg.matrix_norm( | ||
| x2, p='fro', keepdim=False | ||
| ) | ||
| y2_fro_keepdimtrue = paddle.linalg.matrix_norm( | ||
| x2, p='fro', keepdim=True | ||
| ) | ||
| y2_p_keepdimfalse = paddle.linalg.matrix_norm( | ||
| x2, p=1, axis=[0, -1], keepdim=False | ||
| ) | ||
| y2_p_keepdimtrue = paddle.linalg.matrix_norm( | ||
| x2, p=1, axis=[0, -1], keepdim=True | ||
| ) | ||
| self.assertRaises( | ||
| ValueError, paddle.linalg.matrix_norm, x2, p=2, axis=[0, -1] | ||
| ) | ||
| self.assertEqual(y1_fro_keepdimfalse.shape, []) | ||
| self.assertEqual(y1_fro_keepdimtrue.shape, [1, 1]) | ||
| self.assertEqual(y2_fro_keepdimfalse.shape, x2.shape[:-2]) | ||
| self.assertEqual(y2_fro_keepdimtrue.shape, [2, 1, 1]) | ||
| self.assertEqual(y2_p_keepdimfalse.shape, []) | ||
| self.assertEqual(y2_p_keepdimtrue.shape, [2, 1, 1]) | ||
| self.assertEqual(y1_p.shape, []) |
There was a problem hiding this comment.
可以增加一个单测，[3,0,2,0], axis=[1,-1]
|
Sorry to inform you that a6845c9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
解决存在matrix_norm 0 size tensor的报错
