【BUPT】【Paddle Tensor 第二期 API支持 0-size Tensor】paddle.matrix_power 支持 0-size tensor #70098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Comment on lines
191
to
202
| bool has_zero_dim = false; | ||
| for (int i = 0; i < x_ndim; i++) { | ||
| if (x_dims[i] == 0) { | ||
| has_zero_dim = true; | ||
| break; | ||
| } | ||
| } | ||
| if (has_zero_dim) { | ||
| Out->Resize(X->dims()); | ||
| ctx.template Alloc<T>(Out); | ||
| return; | ||
| } |
There was a problem hiding this comment.
可以化简下
Suggested change
| bool has_zero_dim = false; | |
| for (int i = 0; i < x_ndim; i++) { | |
| if (x_dims[i] == 0) { | |
| has_zero_dim = true; | |
| break; | |
| } | |
| } | |
| if (has_zero_dim) { | |
| Out->Resize(X->dims()); | |
| ctx.template Alloc<T>(Out); | |
| return; | |
| } | |
| if (x->numel() == 0) { | |
| Out->Resize(X->dims()); | |
| ctx.template Alloc<T>(Out); | |
| return; | |
| } |
Comment on lines
203
to
205
| PADDLE_ENFORCE_EQ( | ||
| x_dims[x_ndim - 2], | ||
| x_dims[x_ndim - 1], |
There was a problem hiding this comment.
上面的逻辑应该放在203行的检查之后，0-size Tensor也应该符合方阵的要求
|
|
||
| def _test_matrix_power_empty_dynamtic(self): | ||
| with dygraph_guard(): | ||
| x = paddle.full((0, 0), 1.0, dtype='float32') |
There was a problem hiding this comment.
可以多测试几组，如[0,0]、[0,6]、[6,0]、[2,3,0,0]这种形状
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Comment on lines
471
to
472
| assert len(y4.shape) == 4 and y4.shape[0] == 2 and y4.shape[1] == 3 | ||
| assert len(y.shape) == 2 and y.shape[0] == 0 and y.shape[1] == 0 |
There was a problem hiding this comment.
- 使用self.assertEqual而不是assert
- 对于形状的判断，直接使用：y4.shape == [2, 3, 0, 0]即可，没必要把每个元素都写出来，y的形状判断同理
74 tasks
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
解决x.dim=0出现的报错
