[SOT][Faster Guard] adapt to faster guard for more variables #69411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zrr1999
changed the title
SigureMo
approved these changes
Nov 15, 2024
| @@ -148,6 +148,19 @@ class ShapeMatchGuard : public GuardBase { | |||
| std::vector<std::optional<int64_t>> expected_; | |||
| }; | |||
|
|
|||
| class AttributeMatchGuard : public GuardBase { | |||
There was a problem hiding this comment.
AttributeMatchGuard(v, "attr").check(x) 会比 ValueMatchGuard(v).check(x.attr) 快一些是么？
这里我的一个考虑是，如果 IR 表示（表达式树）上包含的是 value_guard_1(x.attr) and value_guard_2(x.attr) 是可以消除公共子表达式的，而 attr_guard_1(x, attr) and attr_guard_2(x, attr) 则是相对来说会更难优化的，这在后续设计时可以考虑下
如果 AttributeMatchGuard 是有优化的，这里可以考虑在最开始 build 的 Guard 树上不体现 AttributeMatchGuard，以确保公共子表达式消除等优化是可以作用的，最后通过 Pass 将 value_guard_1(x.attr) fuse 成 attr_guard_1(x, attr)
有点组合算子的意思，IR 上最开始生成的以及后续 Pass 处理的是基础 Guard，经过图变换、融合生成高性能的组合 Guard
zrr1999
changed the title
SigureMo
changed the title
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description