Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paddle Tensorrt] change int32 to int64 in test file #69191

Merged
merged 14 commits into from
Dec 17, 2024

Conversation

Hanyonggong
Copy link
Contributor

@Hanyonggong Hanyonggong commented Nov 5, 2024

PR Category

Inference

PR Types

Bug fixes

Description

card-71500
将测试文件中的int32转为int64操作,并删除test_trt_marker

Copy link

paddle-bot bot commented Nov 5, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 5, 2024
Comment on lines 43 to 44
"x": np.random.randn(7, 3).astype(np.int32),
"out_dtype": np.int64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast处理的不是shape tensor,这里没必要这样修改吧,改了反而测试不到float16的场景了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

YuanRisheng
YuanRisheng previously approved these changes Nov 6, 2024
XieYunshen
XieYunshen previously approved these changes Nov 11, 2024
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码提交有问题吧,third_party目录应该不需要修改吧

YuanRisheng
YuanRisheng previously approved these changes Dec 9, 2024
@@ -54,8 +54,8 @@ class TestLessThanFloat32TRTPattern(TensorRTBaseTest):
def setUp(self):
self.python_api = paddle.less_than
self.api_args = {
"x": np.random.randn(2, 3).astype(np.float32),
"y": np.random.randn(3).astype(np.float32),
"x": np.random.randn(2, 3).astype("float32"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这类修改的作用是什么呢?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

规范了样式

XieYunshen
XieYunshen previously approved these changes Dec 9, 2024
lizexu123
lizexu123 previously approved these changes Dec 11, 2024
wanghuancoder
wanghuancoder previously approved these changes Dec 11, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea previously approved these changes Dec 11, 2024
@lizexu123 lizexu123 merged commit 7635015 into PaddlePaddle:develop Dec 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants