Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 7th No.19】NO.19为 Paddle 新增 load_state_dict_from_url API v1 #68507

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

zty-king
Copy link

@zty-king zty-king commented Sep 28, 2024

PR Category

User Experience

PR Types

Improvements

Description

【Hackathon 7th No.19】NO.19为 Paddle 新增 load_state_dict_from_url API v1

Copy link

paddle-bot bot commented Sep 28, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zty-king
Copy link
Author

@luotao1 您好,想问问最后这两个CI报错是什么原因,没看太懂,麻烦了

@paddle-bot paddle-bot bot added the contributor External developers label Sep 28, 2024
@luotao1
Copy link
Contributor

luotao1 commented Sep 29, 2024

image
  • Coverage这条:是覆盖率不够,需要行覆盖率90%以上才能通过,因此要加单侧。
  • Inference这条:看上去是网络不好,给你rerun了

@zty-king
Copy link
Author

zty-king commented Sep 29, 2024

@luotao1 你好它这个coverage当时交了单测和我修改的api对应的py文件,测的是通过的,现在我修改了一点单测的格式,重新提交,coverage又显示有问题了,请问这个该怎么处理,我看是因为它只识别了我新上传的改动

@luotao1
Copy link
Contributor

luotao1 commented Sep 30, 2024

@zty-king
Copy link
Author

@luotao1 您好,我的单测还需要验证一个下载ZIP文件并解包的测试,我在本地运行单侧都没问题,但是目前手上没有能够提供公网访问的服务器,请问您这边能提供我一个网站,上传ZIP并且可以下载该ZIP文件嘛,commit之后,CI会进行测试,会涉及到从网站下载的步骤,它访问不到我的http服务就会报错

@zty-king
Copy link
Author

zty-king commented Oct 1, 2024

image
本地跑单测没问题,上传之后CI提示这个路径的文件不存在,我上传了也不行,请问该怎么解决

@luotao1
Copy link
Contributor

luotao1 commented Oct 8, 2024

这个zip有多大,可以直接拖到github评论区,我帮你上传后,你测试下。

@zty-king
Copy link
Author

zty-king commented Oct 8, 2024

这个zip有多大,可以直接拖到github评论区,我帮你上传后,你测试下。

@luotao1 这个有49.9MB,评论区上传提示最大25MB

weight1 = paddle.load(self.weight_path)
model1.set_state_dict(weight1)
model2 = self.model
weight2 = paddle.hapi.hub.load_state_dict_from_url(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PR里面不要上传模型。
image
  1. 【Hackathon 7th No.19】为 Paddle 新增 load_state_dict_from_url API v1 community#958 (comment) 已有的可以用么?
  2. zip功能,可以搜下已有的.zip包,看是否满足需求。
image

Copy link
Author

@zty-king zty-king Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luotao1
第2点那个已经有的模型权重是可以用的,我也成功用新增的API下载并加载了,但是我现在验证load_state_dict_from_url这个API的单测逻辑是:
用paddle.load加载本地的权重文件 和 load_state_dict_from_url下载网页的权重文件并加载,来对比这两个权重文件是否一致,因此需要用到本地的权重文件

Copy link

paddle-ci-bot bot commented Oct 9, 2024

Sorry to inform you that 8ac0515's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zty-king
Copy link
Author

zty-king commented Oct 9, 2024

@luotao1 请问您这边能用如流接收一下我的zip文件帮我上传,我来测试下载嘛,本地文件我就回退了,不上传了,换别的方式来验证

@luotao1
Copy link
Contributor

luotao1 commented Oct 9, 2024

可以的,我今天就已经加了你,等着你通过~

@luotao1 luotao1 added the API label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants