-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[DLPACK] Refine typehint for from_dlpack #68305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HydrogenSulfate
merged 8 commits into
PaddlePaddle:develop
from
HydrogenSulfate:refine_dlpack_typehint
Sep 23, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
203640e
refine typehint for from_dlpack
HydrogenSulfate 564f96a
update docstring of from_dlpack/to_dlpack
HydrogenSulfate 3ef06d0
Merge branch 'develop' into refine_dlpack_typehint
HydrogenSulfate 765c7d7
remove blankline
HydrogenSulfate 0e1e3fb
fix doctest skip
HydrogenSulfate 02f626e
ignore type checking
HydrogenSulfate 4173ea3
split into 2 code block
HydrogenSulfate ae9c41e
use -(test=document_fix)
HydrogenSulfate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要不要拆分成两段示例代码?看起来比较独立
拆分示例代码需要为每段添加 name(可以全局搜
:name:参考)然后中文文档需要分别引用两段代码,可参考
https://github.com/PaddlePaddle/docs/blob/3db4cd854485ca4b9c74dd3ed8364be25746a776/docs/api/paddle/diag_cn.rst?plain=1#L31-L39