[Prim][PIR] Support dynamic shape for scatter_grad and add the comp detection for all the backward dynamic shape test case #68168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroRains
requested review from
Aurelius84,
cxxly,
xiaoguoguo626807,
changeyoung98 and
cyber-pioneer
as code owners
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
||
|
|
||
| class TestPrimBatchNormWithGrad3(TestPrimThreeWithGrad): | ||
| def setUp(self): | ||
| np.random.seed(2023) | ||
| self.op_name = "pd_op.batch_norm_grad_" |
There was a problem hiding this comment.
这个地方是不是写错了 应该是batch_norm__grad
There was a problem hiding this comment.
这个地方笔误了，应该就是pd_op.batch_norm_grad，他算子名只有前向是有下划线的，反向的话应该就是这个pd_op.batch_norm_grad
There was a problem hiding this comment.
这个应该问题不大，之前我打印出来是拆解了的，可以先合入，然后我在#68076 这个PR里再一起修改
xiaoguoguo626807
approved these changes
Sep 13, 2024
xiaoguoguo626807
merged commit a40ea5e
into
PaddlePaddle:develop
29 of 30 checks passed
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
New features
Description
为scatter_grad 添加动态shape支持，添加scatter_nd_add_grad的动态shape单测，为所有反向动态shape测试添加拆解检测