[SOT][dynamic shape] Fallback static shape all symvar #68113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that c807af6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
SigureMo
reviewed
Sep 18, 2024
| isinstance(arg, SymbolicVariable) | ||
| for arg in flatten_vars | ||
| ): | ||
| # TODO(zrr1999): maybe we can continue to fallback to all args are constant. |
There was a problem hiding this comment.
这块应该是指 e.name in bound_arguments.arguments 但是依然报错了还是可以继续fallback，比如name有人手抖写成另一个参数了
There was a problem hiding this comment.
这块应该是指 e.name in bound_arguments.arguments 但是依然报错了还是可以继续fallback，比如name有人手抖写成另一个参数了。不过感觉加上会增加复杂性而且感觉好像也遇不到
|
|
SigureMo
changed the title
SigureMo
changed the title
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
找不到对应的arg时fallback到全部symvar退化为const