-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Fix PIR Unittest No.527 BUAA】Fix some test case in PIR #66194
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
Wujianyu03 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是所有单测崩溃了就那with paddle.pir_utils.OldIrGuard():包一下就行了。
只有:明确不需要测试PIR的才做with paddle.pir_utils.OldIrGuard():包裹。
绝大多数是要修问题,而不是通过with paddle.pir_utils.OldIrGuard():规避问题。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
但PR描述下次最好详细一些,截图太少了,还应介绍你的问题、修复思路。
已补全~ |
…#66194) * fix test_tril_triu_op * fix test_where_op * fix cmake * fix codestyle * fix * restore test_where_op.py
…#66194) * fix test_tril_triu_op * fix test_where_op * fix cmake * fix codestyle * fix * restore test_where_op.py
…#66194) * fix test_tril_triu_op * fix test_where_op * fix cmake * fix codestyle * fix * restore test_where_op.py
PR Category
Others
PR Types
Others
Description
pir模式下并没有进行类型检查,仿照静态图补全类型检查,抛出对应异常。
为避免检查对动态图速度的影响,拆分判断。修改后代码如下: