Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Fix PIR Unittest No.141 BUAA】Fix some test case in PIR #66175

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

uanu2002
Copy link
Contributor

@uanu2002 uanu2002 commented Jul 18, 2024

PR Category

Others

PR Types

Others

Description

Fix some bugs in test_cumsum_op.

PIR不支持.name,所以这个test_name可以跳过PIR的测试。

关联Issue:#63740

Copy link

paddle-bot bot commented Jul 18, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Wujianyu03 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 18, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 18, 2024
@uanu2002 uanu2002 changed the title 【Fix PIR Unittest No.141 309】Fix some test case in PIR 【Fix PIR Unittest No.141 309 BUAA】Fix some test case in PIR Jul 19, 2024
shutil.rmtree(self.save_dir)

def test_earlystopping(self):
with paddle.pir_utils.OldIrGuard():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个单测没看出来需要使用with paddle.pir_utils.OldIrGuard():的必要,如果存在问题应该修问题,而不是通过with paddle.pir_utils.OldIrGuard():规避问题。

@uanu2002 uanu2002 changed the title 【Fix PIR Unittest No.141 309 BUAA】Fix some test case in PIR 【Fix PIR Unittest No.141 BUAA】Fix some test case in PIR Jul 22, 2024
@uanu2002 uanu2002 requested a review from wanghuancoder July 22, 2024 08:43
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit a5a133b into PaddlePaddle:develop Jul 23, 2024
31 checks passed
inaomIIsfarell pushed a commit to inaomIIsfarell/Paddle that referenced this pull request Jul 31, 2024
…#66175)

* fix some test cases in pir

* fix some test cases in pir

* fix cmake file

* fix codestyle

* fix

* fix
@uanu2002 uanu2002 deleted the develop2 branch August 1, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants