-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Fix PIR Unittest No.141 BUAA】Fix some test case in PIR #66175
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
Wujianyu03 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
shutil.rmtree(self.save_dir) | ||
|
||
def test_earlystopping(self): | ||
with paddle.pir_utils.OldIrGuard(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个单测没看出来需要使用with paddle.pir_utils.OldIrGuard():的必要,如果存在问题应该修问题,而不是通过with paddle.pir_utils.OldIrGuard():规避问题。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#66175) * fix some test cases in pir * fix some test cases in pir * fix cmake file * fix codestyle * fix * fix
PR Category
Others
PR Types
Others
Description
Fix some bugs in test_cumsum_op.
PIR不支持.name,所以这个test_name可以跳过PIR的测试。
关联Issue:#63740