Wrong parameter order in all_to_all#65093
Merged
JZ-LIANG merged 1 commit intoPaddlePaddle:developfrom Jun 21, 2024
Merged
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
Collaborator
|
CI failed but it was NOT related to this PR ERROR: test_simple_net_hybrid_strategy (__main__.TestSemiAutoParallelLlamaDataLoader)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/workspace/Paddle/test/collective/test_communication_api_base.py", line 79, in run_test_case
self._launcher = subprocess.run(
File "/usr/lib/python3.10/subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/python', '-u', '-m', 'paddle.distributed.launch', '--log_dir', '/tmp/tmpkx_sv8w9', '--devices', '0,1,2,3,4,5,6,7', 'semi_auto_llama_dataloader.py']' returned non-zero exit status 1.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/workspace/Paddle/test/auto_parallel/hybrid_strategy/test_semi_auto_parallel_llama_model.py", line 224, in test_simple_net_hybrid_strategy
self.run_test_case(
File "/workspace/Paddle/test/collective/test_communication_api_base.py", line 90, in run_test_case
raise RuntimeError(
RuntimeError: Error occurs when running this test case. The return code of command ['/usr/bin/python', '-u', '-m', 'paddle.distributed.launch', '--log_dir', '/tmp/tmpkx_sv8w9', '--devices', '0,1,2,3,4,5,6,7', 'semi_auto_llama_dataloader.py'] is 1
----------------------------------------------------------------------
Ran 9 tests in 444.641s
FAILED (errors=1) |
Collaborator
|
这个问题还在修复中,修复后我会重新执行这个CI |
JZ-LIANG
reviewed
Jun 21, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
Co-authored-by: lawrence910426 <lawu@nvidia.com>
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
Co-authored-by: lawrence910426 <lawu@nvidia.com>
deepllz
added a commit
to deepllz/Paddle
that referenced
this pull request
Jul 4, 2024
This reverts commit 5d3df27.
sneaxiy
pushed a commit
that referenced
this pull request
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Distributed Strategy
PR Types
Bug fixes
Description
The parameter order in PyBind differs from that in Python, causing a bug. By swapping the parameter order, this issue can be resolved.
Please refer to the PyBind C++ Interface (all_to_all_tensor_on_calc_stream and all_to_all_tensor.), where
out_tensorshould be the first parameter.However, in the
_all_to_all_tensor_in_dygraph,in_tensoris the first parameter.Additionally, the parameter order in PaddlePaddle is not standardized, even in the highest-level APIs, which lack a consistent parameter sequence. Please check alltoall (stream) and alltoall (distributed)