Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR Dist Op Reg No.29】 reg prune_gate_by_capacity #62494

Merged

Conversation

xiaoyewww
Copy link
Contributor

PR types

Others

PR changes

Others

Description

#60436
注册算子prune_gate_by_capacity

Copy link

paddle-bot bot commented Mar 6, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 6, 2024
@xiaoyewww xiaoyewww force-pushed the pir/prune_gate_by_capacity branch 2 times, most recently from 71672e6 to ca3a422 Compare March 12, 2024 07:10
@xiaoyewww
Copy link
Contributor Author

@kangguangli 这里ci好像因为覆盖率的问题没过,麻烦review一下

func : PruneGateByCapacityInferMeta
kernel :
func : prune_gate_by_capacity
data_type : dtype
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data_type : dtype
data_type : gate_idx

这个字段是指kernel的dtype要和哪个输入保持一致

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改~

@xiaoyewww xiaoyewww force-pushed the pir/prune_gate_by_capacity branch from 62de950 to e0addc4 Compare March 15, 2024 02:55
@xiaoyewww
Copy link
Contributor Author

@kangguangli 这个麻烦再review一下~

@@ -3799,6 +3799,12 @@
inputs :
x : X

- op: prune_gate_by_capacity
inputs:
{gate_idx: GateIdx, expert_count: ExpertCount, n_expert: n_expert, n_worker: n_worker}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{gate_idx: GateIdx, expert_count: ExpertCount, n_expert: n_expert, n_worker: n_worker}
{gate_idx: GateIdx, expert_count: ExpertCount,}

这里主要是为了配置名称的映射关系。默认是名称相同的,所以如果同名的话,就不用添加在yaml中,更建议删去。

@kangguangli kangguangli merged commit e4de989 into PaddlePaddle:develop Mar 18, 2024
30 checks passed
@xiaoyewww xiaoyewww deleted the pir/prune_gate_by_capacity branch May 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants