API improvement for nn.functional.upsample #61974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Feb 23, 2024
| @@ -906,6 +906,13 @@ def upsample( | |||
| [2, 3, 12, 12] | |||
|
|
|||
| """ | |||
| if data_format == 'NCHW': | |||
There was a problem hiding this comment.
- data_format默认值可以为None，在None的情况下，1D默认NCW，2D默认NCHW，3D默认NCDHW。
- 直接在interpolate里修改吧，在最底层改，上层的API都会支持
- 这些逻辑要在API文档里写清楚，包括所有涉及到的API：interpolate、upsampe、Upsample等，参数里对x的描述、对data_format的描述都需要写清楚新的逻辑
后续的API改动注意更新英文API文档，合入后记得更新doc里的中文API文档
zhwesky2010
previously approved these changes
Feb 26, 2024
| the output will be consistent with that of the input. An optional string from:`"NCW"`, | ||
| `"NWC"`, `"NCHW"`, `"NHWC"`, `"NCDHW"`, `"NDHWC"`. The default value is None. | ||
| When :attr:`data_format` is not specified, it will be automatically inferred from the | ||
| input shape of :attr:`x`. When :attr:`x` is a 3-D Tensor, :attr:`data_format` will be |
zhwesky2010
approved these changes
Feb 26, 2024
sunzhongkai588
approved these changes
Feb 27, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
continue the work of: #56471