【PIR Dist Op Reg No.27】 reg distributed_fused_lamb #61293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
这个Op有其他单测测到吗？如果没有的话麻烦加一个单测 |
kangguangli
reviewed
Mar 7, 2024
xingmingyyj
reviewed
Mar 11, 2024
There was a problem hiding this comment.
param : [param, grad, fp32_fused_param, fp32fusedgrad, fp16fusedparam, fp16fusedgrad, moment1, moment2, beta1pow, beta2pow, fusedparamoffsets, fp32shardfusedparamoffsets, fp16shardfusedparamoffsets, fp16shardfusedparamoffsets, paraminfo, paramorder, learningrate, globalscale, acc_steps, beta1, beta2, epsilon, max_global_grad_norm, weight_decay, clip_after_allreduce, use_master_param_norm, use_master_acc_grad, is_grad_scaled_by_nranks, use_hierarchical_allreduce, nranks, ring_ids]这里的fp32shardfusedparamoffsets重复了，导致参数没对齐
kangguangli
reviewed
Mar 12, 2024
kangguangli
previously approved these changes
Apr 1, 2024
kangguangli
previously approved these changes
Apr 7, 2024
zyfncg
previously approved these changes
Apr 7, 2024
kangguangli
previously approved these changes
Apr 7, 2024
kangguangli
reviewed
Apr 7, 2024
xingmingyyj
approved these changes
Apr 8, 2024
kangguangli
approved these changes
Apr 8, 2024
zyfncg
approved these changes
Apr 9, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 9, 2024
* fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix --------- Co-authored-by: kangguangli <[email protected]>
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 10, 2024
* fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix --------- Co-authored-by: kangguangli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Devs
Description
No27 distributed_fused_lamb